Messages in this thread | | | Subject | Re: [PATCH][next] ASoC: Intel: Skylake: Avoid the use of one-element array | From | Amadeusz Sławiński <> | Date | Mon, 20 Jul 2020 11:11:49 +0200 |
| |
Looks ok and tests on our side also pass.
Reviewed-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com>
On 7/17/2020 11:55 PM, Gustavo A. R. Silva wrote: > One-element arrays are being deprecated[1]. Replace the one-element > array with a simple value type 'u8 reserved'[2], once it seems this > is just a placeholder for alignment. > > [1] https://github.com/KSPP/linux/issues/79 > [2] https://github.com/KSPP/linux/issues/86 > > Tested-by: kernel test robot <lkp@intel.com> > Link: https://github.com/GustavoARSilva/linux-hardening/blob/master/cii/0-day/skylake-20200717.md > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> > --- > sound/soc/intel/skylake/skl-topology.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/intel/skylake/skl-topology.h b/sound/soc/intel/skylake/skl-topology.h > index 9889f728752c..5e93ad85e06d 100644 > --- a/sound/soc/intel/skylake/skl-topology.h > +++ b/sound/soc/intel/skylake/skl-topology.h > @@ -97,7 +97,7 @@ struct skl_audio_data_format { > u8 number_of_channels; > u8 valid_bit_depth; > u8 sample_type; > - u8 reserved[1]; > + u8 reserved; > } __packed; > > struct skl_base_cfg { >
| |