Messages in this thread | | | From | Anand Moon <> | Date | Mon, 20 Jul 2020 14:28:07 +0530 | Subject | Re: [PATCH v4] phy: samsung: Use readl_poll_timeout function |
| |
Hi Krzysztof,
On Mon, 20 Jul 2020 at 13:20, Krzysztof Kozlowski <krzk@kernel.org> wrote: > > On Mon, Jul 13, 2020 at 07:42:43AM +0000, Anand Moon wrote: > > Instead of a busy waiting while loop using udelay > > use readl_poll_timeout function to check the condition > > is met or timeout occurs in crport_handshake function. > > readl_poll_timeout is called in non atomic context so > > it safe to sleep until the condition is met. > > > > Fixes: d8c80bb3b55b ("phy: exynos5-usbdrd: Calibrate LOS levels for exynos5420/5800") > > There is no bug in original code so Fixes tag is not appropriate. Remove > it please. > Thanks for your review. Ok I will do that.
> Best regards, > Krzysztof > -Anand
> > Signed-off-by: Anand Moon <linux.amoon@gmail.com> > > --- > > Changes v4: > > Rebased on to of patch [0] https://patchwork.kernel.org/patch/11651673/ > > --Fix the commit message. > > --Fix the error timeout condition for -ETIMEDOUT > > --- > > Changes v3: > > --Fix the commit message. > > --Drop the variable, used the value directly. > > Changes v2: > > --used the default timeout values. > > --Added missing Fixed tags. > > --- > > drivers/phy/samsung/phy-exynos5-usbdrd.c | 39 ++++++++---------------- > > 1 file changed, 12 insertions(+), 27 deletions(-) > >
| |