lkml.org 
[lkml]   [2020]   [Jul]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.7 092/244] bus: ti-sysc: Fix sleeping function called from invalid context for RTC quirk
    Date
    From: Tony Lindgren <tony@atomide.com>

    [ Upstream commit afe6f1eeb08f85e57f0a02b71efb5a0839606aac ]

    With CONFIG_DEBUG_ATOMIC_SLEEP enabled we can see the following with RTC probe:

    BUG: sleeping function called from invalid context at drivers/bus/ti-sysc.c:1736
    ...
    (sysc_quirk_rtc) from [<c060d01c>] (sysc_write_sysconfig+0x1c/0x60)
    (sysc_write_sysconfig) from [<c060d9f4>] (sysc_enable_module+0x11c/0x274)
    (sysc_enable_module) from [<c060f37c>] (sysc_probe+0xe9c/0x1380)
    (sysc_probe) from [<c06e9384>] (platform_drv_probe+0x48/0x98)

    Fixes: e8639e1c986a ("bus: ti-sysc: Handle module unlock quirk needed for some RTC")
    Signed-off-by: Tony Lindgren <tony@atomide.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/bus/ti-sysc.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/bus/ti-sysc.c b/drivers/bus/ti-sysc.c
    index a160c3a1f09a3..a3a279f30177c 100644
    --- a/drivers/bus/ti-sysc.c
    +++ b/drivers/bus/ti-sysc.c
    @@ -1727,8 +1727,8 @@ static void sysc_quirk_rtc(struct sysc *ddata, bool lock)

    local_irq_save(flags);
    /* RTC_STATUS BUSY bit may stay active for 1/32768 seconds (~30 usec) */
    - error = readl_poll_timeout(ddata->module_va + 0x44, val,
    - !(val & BIT(0)), 100, 50);
    + error = readl_poll_timeout_atomic(ddata->module_va + 0x44, val,
    + !(val & BIT(0)), 100, 50);
    if (error)
    dev_warn(ddata->dev, "rtc busy timeout\n");
    /* Now we have ~15 microseconds to read/write various registers */
    --
    2.25.1


    \
     
     \ /
      Last update: 2022-09-17 16:08    [W:4.165 / U:0.496 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site