Messages in this thread | | | Subject | Re: [PATCH v2][next] phy: samsung-ufs: Fix IS_ERR argument | From | "Gustavo A. R. Silva" <> | Date | Mon, 20 Jul 2020 19:58:00 -0500 |
| |
On 7/20/20 19:46, Alim Akhtar wrote: > Hi Gustavo, > >> -----Original Message----- >> From: Gustavo A. R. Silva <gustavoars@kernel.org> >> Sent: 20 July 2020 18:57 >> To: Kishon Vijay Abraham I <kishon@ti.com>; Vinod Koul <vkoul@kernel.org>; >> Seungwon Jeon <essuuj@gmail.com>; Alim Akhtar >> <alim.akhtar@samsung.com>; Kiwoong Kim <kwmad.kim@samsung.com> >> Cc: linux-kernel@vger.kernel.org; Gustavo A. R. Silva > <gustavoars@kernel.org> >> Subject: [PATCH v2][next] phy: samsung-ufs: Fix IS_ERR argument >> >> Fix IS_ERR argument in samsung_ufs_phy_symbol_clk_init(). The proper >> argument to be passed to IS_ERR() is phy->rx1_symbol_clk. >> >> This bug was detected with the help of Coccinelle. >> >> Fixes: bca21e930451 ("phy: samsung-ufs: add UFS PHY driver for samsung > SoC") >> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> >> --- > Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com> >
Thanks, Alim.
-- Gustavo
>> Changes in v2: >> - Update subject line and changelog text. >> >> drivers/phy/samsung/phy-samsung-ufs.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/phy/samsung/phy-samsung-ufs.c >> b/drivers/phy/samsung/phy-samsung-ufs.c >> index 43ef77d1d96c..9832599a0283 100644 >> --- a/drivers/phy/samsung/phy-samsung-ufs.c >> +++ b/drivers/phy/samsung/phy-samsung-ufs.c >> @@ -147,7 +147,7 @@ static int samsung_ufs_phy_symbol_clk_init(struct >> samsung_ufs_phy *phy) >> } >> >> phy->rx1_symbol_clk = devm_clk_get(phy->dev, "rx1_symbol_clk"); >> - if (IS_ERR(phy->rx0_symbol_clk)) { >> + if (IS_ERR(phy->rx1_symbol_clk)) { >> dev_err(phy->dev, "failed to get rx1_symbol_clk clock\n"); >> return PTR_ERR(phy->rx1_symbol_clk); >> } >> -- >> 2.27.0 > >
| |