lkml.org 
[lkml]   [2020]   [Jul]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v3] net: hyperv: add support for vlans in netvsc driver
From
From: Sriram Krishnan <srirakr2@cisco.com>
Date: Mon, 20 Jul 2020 22:15:51 +0530

> + if (skb->protocol == htons(ETH_P_8021Q)) {
> + u16 vlan_tci = 0;
> + skb_reset_mac_header(skb);

Please place an empty line between basic block local variable declarations
and actual code.

> + netdev_err(net,"Pop vlan err %x\n",pop_err);

A space is necessary before "pop_err".

\
 
 \ /
  Last update: 2020-07-21 01:27    [W:1.468 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site