lkml.org 
[lkml]   [2020]   [Jul]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [GIT PULL] VFIO fix for v5.8-rc7
On Mon, 20 Jul 2020 13:33:29 -0700
Linus Torvalds <torvalds@linux-foundation.org> wrote:

> On Mon, Jul 20, 2020 at 7:34 AM Alex Williamson
> <alex.williamson@redhat.com> wrote:
> >
> > VFIO fixes for v5.8-rc7
> >
> > - Fix race with eventfd ctx cleared outside of mutex (Zeng Tao)
>
> Why does this take and then re-take the lock immediately? That just
> looks insane.
>
> I realize that this isn't likely to be a performance-critical path,
> but this is a basic source cleanliness issue. Doing silly things is
> silly, and shouldn't be done, even if they don't matter.

Yup, it's silly. Cornelia identified the same during review and I let
it slide after some counter arguments by the submitter. I see this got
merged, so I'll post a cleanup for v5.9. Thanks for the input,

Alex

\
 
 \ /
  Last update: 2020-07-20 23:02    [W:0.040 / U:0.204 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site