Messages in this thread | | | Date | Mon, 20 Jul 2020 20:34:42 +0200 | From | Andrew Lunn <> | Subject | Re: [PATCH v3 net-next 02/16] qed, qede, qedf: convert link mode from u32 to ETHTOOL_LINK_MODE |
| |
On Mon, Jul 20, 2020 at 09:08:01PM +0300, Alexander Lobakin wrote: > Currently qed driver already ran out of 32 bits to store link modes, > and this doesn't allow to add and support more speeds. > Convert custom link mode to generic Ethtool bitmap and definitions > (convenient Phylink shorthands are used for elegance and readability). > This allowed us to drop all conversions/mappings between the driver > and Ethtool. > > This involves changes in qede and qedf as well, as they used definitions > from shared "qed_if.h". > > Suggested-by: Andrew Lunn <andrew@lunn.ch> > Signed-off-by: Alexander Lobakin <alobakin@marvell.com> > Signed-off-by: Igor Russkikh <irusskikh@marvell.com> > --- > drivers/net/ethernet/qlogic/qed/qed_main.c | 288 ++++++++++-------- > .../net/ethernet/qlogic/qede/qede_ethtool.c | 200 ++++-------- > drivers/scsi/qedf/qedf_main.c | 78 +++-- > include/linux/qed/qed_if.h | 47 +-- > 4 files changed, 268 insertions(+), 345 deletions(-)
Nice diffstat.
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
| |