lkml.org 
[lkml]   [2020]   [Jul]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH V6 03/14] perf/x86/intel: Introduce the fourth fixed counter
From
Date


On 7/20/2020 12:20 PM, Peter Zijlstra wrote:
> On Fri, Jul 17, 2020 at 07:05:43AM -0700, kan.liang@linux.intel.com wrote:
>> /*
>> + * There is no event-code assigned to the fixed-mode PMCs.
>> + *
>> + * For a fixed-mode PMC, which has an equivalent event on a general-purpose
>> + * PMC, the event-code of the equivalent event is used for the fixed-mode PMC,
>> + * e.g., Instr_Retired.Any and CPU_CLK_Unhalted.Core.
>> + *
>> + * For a fixed-mode PMC, which doesn't have an equivalent event, a
>> + * pseudo-encoding is used, e.g., CPU_CLK_Unhalted.Ref and TOPDOWN.SLOTS.
>> + * The pseudo event-code for a fixed-mode PMC must be 0x00.
>> + * The pseudo umask-code is 0x0X. The X indicates the index of the fixed
>> + * counter.
>
> Isn't it X+1 ? Such that 0x0000 is an invalid event? After all, the
> pseudo event for Fixed2 is 0x0300.

I will fix the inaccurate description as below in V7.

+ * The pseudo umask-code is 0xX. The X equals the index of the fixed
+ * counter + 1, e.g., the fixed counter 2 has the pseudo-encoding 0x0300.

Thanks,
Kan

\
 
 \ /
  Last update: 2020-07-20 20:23    [W:0.452 / U:0.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site