lkml.org 
[lkml]   [2020]   [Jul]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 02/14] drbd: remove dead code in device_to_statistics
    Date
    Ever since the switch to blk-mq, a lower device not use by VM
    writeback will not be marked congested, so the check will never
    trigger.

    Signed-off-by: Christoph Hellwig <hch@lst.de>
    ---
    drivers/block/drbd/drbd_nl.c | 6 ------
    1 file changed, 6 deletions(-)

    diff --git a/drivers/block/drbd/drbd_nl.c b/drivers/block/drbd/drbd_nl.c
    index d0d9a549b58388..650372ee2c7822 100644
    --- a/drivers/block/drbd/drbd_nl.c
    +++ b/drivers/block/drbd/drbd_nl.c
    @@ -3370,7 +3370,6 @@ static void device_to_statistics(struct device_statistics *s,
    if (get_ldev(device)) {
    struct drbd_md *md = &device->ldev->md;
    u64 *history_uuids = (u64 *)s->history_uuids;
    - struct request_queue *q;
    int n;

    spin_lock_irq(&md->uuid_lock);
    @@ -3384,11 +3383,6 @@ static void device_to_statistics(struct device_statistics *s,
    spin_unlock_irq(&md->uuid_lock);

    s->dev_disk_flags = md->flags;
    - q = bdev_get_queue(device->ldev->backing_bdev);
    - s->dev_lower_blocked =
    - bdi_congested(q->backing_dev_info,
    - (1 << WB_async_congested) |
    - (1 << WB_sync_congested));
    put_ldev(device);
    }
    s->dev_size = drbd_get_capacity(device->this_bdev);
    --
    2.27.0
    \
     
     \ /
      Last update: 2020-07-20 09:53    [W:4.113 / U:0.168 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site