lkml.org 
[lkml]   [2020]   [Jul]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 009/215] ipv6: Fix use of anycast address with loopback
    Date
    From: David Ahern <dsahern@kernel.org>

    [ Upstream commit aea23c323d89836bcdcee67e49def997ffca043b ]

    Thomas reported a regression with IPv6 and anycast using the following
    reproducer:

    echo 1 > /proc/sys/net/ipv6/conf/all/forwarding
    ip -6 a add fc12::1/16 dev lo
    sleep 2
    echo "pinging lo"
    ping6 -c 2 fc12::

    The conversion of addrconf_f6i_alloc to use ip6_route_info_create missed
    the use of fib6_is_reject which checks addresses added to the loopback
    interface and sets the REJECT flag as needed. Update fib6_is_reject for
    loopback checks to handle RTF_ANYCAST addresses.

    Fixes: c7a1ce397ada ("ipv6: Change addrconf_f6i_alloc to use ip6_route_info_create")
    Reported-by: thomas.gambier@nexedi.com
    Signed-off-by: David Ahern <dsahern@kernel.org>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    net/ipv6/route.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/net/ipv6/route.c
    +++ b/net/ipv6/route.c
    @@ -3409,7 +3409,7 @@ static bool fib6_is_reject(u32 flags, st
    if ((flags & RTF_REJECT) ||
    (dev && (dev->flags & IFF_LOOPBACK) &&
    !(addr_type & IPV6_ADDR_LOOPBACK) &&
    - !(flags & RTF_LOCAL)))
    + !(flags & (RTF_ANYCAST | RTF_LOCAL))))
    return true;

    return false;

    \
     
     \ /
      Last update: 2020-07-20 18:40    [W:2.376 / U:1.552 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site