lkml.org 
[lkml]   [2020]   [Jul]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v3] PCI: hv: Fix a timing issue which causes kdump to fail occasionally
Date
From: Wei Hu <weh@microsoft.com> Sent: Friday, July 17, 2020 8:48 PM
> To: KY Srinivasan <kys@microsoft.com>; Haiyang Zhang <haiyangz@microsoft.com>;
> Stephen Hemminger <sthemmin@microsoft.com>; wei.liu@kernel.org;
> lorenzo.pieralisi@arm.com; robh@kernel.org; bhelgaas@google.com; linux-
> hyperv@vger.kernel.org; linux-pci@vger.kernel.org; linux-kernel@vger.kernel.org; Dexuan
> Cui <decui@microsoft.com>; Michael Kelley <mikelley@microsoft.com>
> Cc: Wei Hu <weh@microsoft.com>
> Subject: [PATCH v3] PCI: hv: Fix a timing issue which causes kdump to fail occasionally
>
> Kdump could fail sometime on Hyper-V guest over Accelerated Network
> interface. This is because the retry in hv_pci_enter_d0() relies on
> an asynchronous host event arriving before the guest calls
> hv_send_resources_allocated(). Fix the problem by moving retry
> to hv_pci_probe(), removing this dependency and making the calling
> sequence synchronous.
>
> Fixes: c81992e7f4aa ("PCI: hv: Retry PCI bus D0 entry on invalid device state")
> Signed-off-by: Wei Hu <weh@microsoft.com>
> ---
> v2: Adding Fixes tag according to Michael Kelley's review comment.
> v3: Fix couple typos and reword commit message to make it clearer.
> Thanks the comments from Bjorn Helgaas.
>
> drivers/pci/controller/pci-hyperv.c | 66 ++++++++++++++---------------
> 1 file changed, 32 insertions(+), 34 deletions(-)
>

I gave my Reviewed-by on the earlier v1 of this patch, but reiterating it
here:

Reviewed-by: Michael Kelley <mikelley@microsoft.com>

\
 
 \ /
  Last update: 2020-07-20 18:40    [W:0.085 / U:0.600 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site