lkml.org 
[lkml]   [2020]   [Jul]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 062/215] Revert "usb/ehci-platform: Set PM runtime as active on resume"
    Date
    This reverts commit 335d720bb4bd9d2808cae5af6f3c636c87f19596.

    Eugeniu Rosca writes:

    On Thu, Jul 09, 2020 at 09:00:23AM +0200, Eugeniu Rosca wrote:
    >After integrating v4.14.186 commit 5410d158ca2a50 ("usb/ehci-platform:
    >Set PM runtime as active on resume") into downstream v4.14.x, we started
    >to consistently experience below panic [1] on every second s2ram of
    >R-Car H3 Salvator-X Renesas reference board.
    >
    >After some investigations, we concluded the following:
    > - the issue does not exist in vanilla v5.8-rc4+
    > - [bisecting shows that] the panic on v4.14.186 is caused by the lack
    > of v5.6-rc1 commit 987351e1ea7772 ("phy: core: Add consumer device
    > link support"). Getting evidence for that is easy. Reverting
    > 987351e1ea7772 in vanilla leads to a similar backtrace [2].
    >
    >Questions:
    > - Backporting 987351e1ea7772 ("phy: core: Add consumer device
    > link support") to v4.14.187 looks challenging enough, so probably not
    > worth it. Anybody to contradict this?
    > - Assuming no plans to backport the missing mainline commit to v4.14.x,
    > should the following three v4.14.186 commits be reverted on v4.14.x?
    > * baef809ea497a4 ("usb/ohci-platform: Fix a warning when hibernating")
    > * 9f33eff4958885 ("usb/xhci-plat: Set PM runtime as active on resume")
    > * 5410d158ca2a50 ("usb/ehci-platform: Set PM runtime as active on resume")

    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/usb/host/ehci-platform.c | 4 ----
    1 file changed, 4 deletions(-)

    diff --git a/drivers/usb/host/ehci-platform.c b/drivers/usb/host/ehci-platform.c
    index e9a49007cce4a..e4fc3f66d43bf 100644
    --- a/drivers/usb/host/ehci-platform.c
    +++ b/drivers/usb/host/ehci-platform.c
    @@ -455,10 +455,6 @@ static int ehci_platform_resume(struct device *dev)

    ehci_resume(hcd, priv->reset_on_resume);

    - pm_runtime_disable(dev);
    - pm_runtime_set_active(dev);
    - pm_runtime_enable(dev);
    -
    if (priv->quirk_poll)
    quirk_poll_init(priv);

    --
    2.25.1


    \
     
     \ /
      Last update: 2020-07-20 18:28    [W:4.957 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site