lkml.org 
[lkml]   [2020]   [Jul]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 138/215] mtd: rawnand: oxnas: Unregister all devices on error
    Date
    From: Miquel Raynal <miquel.raynal@bootlin.com>

    commit b60391eb17b2956ff2fc4c348e5a464da21ff9cb upstream.

    On error, the oxnas probe path just frees the device which failed and
    aborts the probe, leaving unreleased resources.

    Fix this situation by calling mtd_device_unregister()/nand_cleanup()
    on these.

    Fixes: 668592492409 ("mtd: nand: Add OX820 NAND Support")
    Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
    Link: https://lore.kernel.org/linux-mtd/20200519130035.1883-38-miquel.raynal@bootlin.com
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/mtd/nand/raw/oxnas_nand.c | 8 ++++++++
    1 file changed, 8 insertions(+)

    --- a/drivers/mtd/nand/raw/oxnas_nand.c
    +++ b/drivers/mtd/nand/raw/oxnas_nand.c
    @@ -82,6 +82,7 @@ static int oxnas_nand_probe(struct platf
    struct resource *res;
    int count = 0;
    int err = 0;
    + int i;

    /* Allocate memory for the device structure (and zero it) */
    oxnas = devm_kzalloc(&pdev->dev, sizeof(*oxnas),
    @@ -161,6 +162,13 @@ err_cleanup_nand:
    nand_cleanup(chip);
    err_release_child:
    of_node_put(nand_np);
    +
    + for (i = 0; i < oxnas->nchips; i++) {
    + chip = oxnas->chips[i];
    + WARN_ON(mtd_device_unregister(nand_to_mtd(chip)));
    + nand_cleanup(chip);
    + }
    +
    err_clk_unprepare:
    clk_disable_unprepare(oxnas->clk);
    return err;

    \
     
     \ /
      Last update: 2020-07-20 18:24    [W:4.125 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site