lkml.org 
[lkml]   [2020]   [Jul]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.7 085/244] phy: rockchip: Fix return value of inno_dsidphy_probe()
    Date
    From: Tiezhu Yang <yangtiezhu@loongson.cn>

    [ Upstream commit fdc355a03df537bc8d8909b86d1688fe07c7032b ]

    When call function devm_platform_ioremap_resource(), we should use IS_ERR()
    to check the return value and return PTR_ERR() if failed.

    Fixes: b7535a3bc0ba ("phy/rockchip: Add support for Innosilicon MIPI/LVDS/TTL PHY")
    Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
    Reviewed-by: Heiko Stuebner <heiko@sntech.de>
    Link: https://lore.kernel.org/r/1590412138-13903-1-git-send-email-yangtiezhu@loongson.cn
    Signed-off-by: Vinod Koul <vkoul@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/phy/rockchip/phy-rockchip-inno-dsidphy.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/phy/rockchip/phy-rockchip-inno-dsidphy.c b/drivers/phy/rockchip/phy-rockchip-inno-dsidphy.c
    index a7c6c940a3a8c..8af8c6c5cc028 100644
    --- a/drivers/phy/rockchip/phy-rockchip-inno-dsidphy.c
    +++ b/drivers/phy/rockchip/phy-rockchip-inno-dsidphy.c
    @@ -607,8 +607,8 @@ static int inno_dsidphy_probe(struct platform_device *pdev)
    platform_set_drvdata(pdev, inno);

    inno->phy_base = devm_platform_ioremap_resource(pdev, 0);
    - if (!inno->phy_base)
    - return -ENOMEM;
    + if (IS_ERR(inno->phy_base))
    + return PTR_ERR(inno->phy_base);

    inno->ref_clk = devm_clk_get(dev, "ref");
    if (IS_ERR(inno->ref_clk)) {
    --
    2.25.1


    \
     
     \ /
      Last update: 2020-07-20 18:11    [W:3.890 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site