lkml.org 
[lkml]   [2020]   [Jul]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 139/215] mtd: rawnand: oxnas: Release all devices in the _remove() path
    Date
    From: Miquel Raynal <miquel.raynal@bootlin.com>

    commit 0a5f45e57e35d0840bedb816974ce2e63406cd8b upstream.

    oxnans_nand_remove() should release all MTD devices and clean all NAND
    devices, not only the first one registered.

    Fixes: 668592492409 ("mtd: nand: Add OX820 NAND Support")
    Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
    Link: https://lore.kernel.org/linux-mtd/20200519130035.1883-39-miquel.raynal@bootlin.com
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/mtd/nand/raw/oxnas_nand.c | 8 ++++++--
    1 file changed, 6 insertions(+), 2 deletions(-)

    --- a/drivers/mtd/nand/raw/oxnas_nand.c
    +++ b/drivers/mtd/nand/raw/oxnas_nand.c
    @@ -177,9 +177,13 @@ err_clk_unprepare:
    static int oxnas_nand_remove(struct platform_device *pdev)
    {
    struct oxnas_nand_ctrl *oxnas = platform_get_drvdata(pdev);
    + struct nand_chip *chip;
    + int i;

    - if (oxnas->chips[0])
    - nand_release(oxnas->chips[0]);
    + for (i = 0; i < oxnas->nchips; i++) {
    + chip = oxnas->chips[i];
    + nand_release(chip);
    + }

    clk_disable_unprepare(oxnas->clk);


    \
     
     \ /
      Last update: 2020-07-20 18:02    [W:3.262 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site