lkml.org 
[lkml]   [2020]   [Jul]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 106/215] usb: gadget: udc: atmel: fix uninitialized read in debug printk
    Date
    From: Michał Mirosław <mirq-linux@rere.qmqm.pl>

    [ Upstream commit 30517ffeb3bff842e1355cbc32f1959d9dbb5414 ]

    Fixed commit moved the assignment of 'req', but did not update a
    reference in the DBG() call. Use the argument as it was renamed.

    Fixes: 5fb694f96e7c ("usb: gadget: udc: atmel: fix possible oops when unloading module")
    Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
    Signed-off-by: Felipe Balbi <balbi@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/usb/gadget/udc/atmel_usba_udc.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c b/drivers/usb/gadget/udc/atmel_usba_udc.c
    index 58e5b015d40e6..bebe814f55e6a 100644
    --- a/drivers/usb/gadget/udc/atmel_usba_udc.c
    +++ b/drivers/usb/gadget/udc/atmel_usba_udc.c
    @@ -870,7 +870,7 @@ static int usba_ep_dequeue(struct usb_ep *_ep, struct usb_request *_req)
    u32 status;

    DBG(DBG_GADGET | DBG_QUEUE, "ep_dequeue: %s, req %p\n",
    - ep->ep.name, req);
    + ep->ep.name, _req);

    spin_lock_irqsave(&udc->lock, flags);

    --
    2.25.1


    \
     
     \ /
      Last update: 2020-07-20 18:00    [W:2.079 / U:0.056 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site