lkml.org 
[lkml]   [2020]   [Jul]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 059/215] net: ethernet: mvneta: Do not error out in non serdes modes
    Date
    From: Sascha Hauer <s.hauer@pengutronix.de>

    [ Upstream commit d3d239dcb8aae6d7b10642d292b404e57604f7ea ]

    In mvneta_config_interface() the RGMII modes are catched by the default
    case which is an error return. The RGMII modes are valid modes for the
    driver, so instead of returning an error add a break statement to return
    successfully.

    This avoids this warning for non comphy SoCs which use RGMII, like
    SolidRun Clearfog:

    WARNING: CPU: 0 PID: 268 at drivers/net/ethernet/marvell/mvneta.c:3512 mvneta_start_dev+0x220/0x23c

    Fixes: b4748553f53f ("net: ethernet: mvneta: Fix Serdes configuration for SoCs without comphy")
    Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
    Reviewed-by: Russell King <rmk+kernel@armlinux.org.uk>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ethernet/marvell/mvneta.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c
    index ffdb7b113f172..d443cd19e8951 100644
    --- a/drivers/net/ethernet/marvell/mvneta.c
    +++ b/drivers/net/ethernet/marvell/mvneta.c
    @@ -3206,7 +3206,7 @@ static int mvneta_config_interface(struct mvneta_port *pp,
    MVNETA_HSGMII_SERDES_PROTO);
    break;
    default:
    - return -EINVAL;
    + break;
    }
    }

    --
    2.25.1


    \
     
     \ /
      Last update: 2020-07-20 17:58    [W:4.588 / U:0.140 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site