lkml.org 
[lkml]   [2020]   [Jul]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC PATCH 01/10] timer: Prevent base->clk from moving backward
    On 02/07/20 16:32, Frederic Weisbecker wrote:
    > On Thu, Jul 02, 2020 at 11:59:59AM +0200, Juri Lelli wrote:
    > > On 02/07/20 01:20, Frederic Weisbecker wrote:
    > > > On Wed, Jul 01, 2020 at 06:35:04PM +0200, Juri Lelli wrote:
    > > > > Guess you might be faster to understand what I'm missing. :-)
    > > >
    > > > So, did you port only this patch or the whole set in order to
    > > > trigger this?
    > > >
    > > > If it was the whole set, can you try this patch alone?
    > >
    > > Whole set. And I can't reproduce if I try with this patch alone.
    > >
    >
    > Missing initialization. This should go better after this:
    >
    > diff --git a/kernel/time/timer.c b/kernel/time/timer.c
    > index 25a55c043297..f36b53219768 100644
    > --- a/kernel/time/timer.c
    > +++ b/kernel/time/timer.c
    > @@ -1969,6 +1969,7 @@ static void __init init_timer_cpu(int cpu)
    > base->cpu = cpu;
    > raw_spin_lock_init(&base->lock);
    > base->clk = jiffies;
    > + base->next_expiry = base->clk + NEXT_TIMER_MAX_DELTA;
    > timer_base_init_expiry_lock(base);
    > }
    > }
    >

    Yep. Looks like warning is gone.

    \
     
     \ /
      Last update: 2020-07-02 17:58    [W:5.324 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site