Messages in this thread | | | Date | Thu, 2 Jul 2020 16:42:07 +0100 | From | Mark Brown <> | Subject | Re: [PATCH 1/2] dt-bindings: sound: fsl-asoc-card: add new compatible for I2S slave |
| |
On Thu, Jul 02, 2020 at 05:28:03PM +0200, Arnaud Ferraris wrote: > Le 02/07/2020 à 16:31, Mark Brown a écrit :
> > Why require that the CODEC be clock master here - why not make this > > configurable, reusing the properties from the generic and audio graph > > cards?
> This is partly because I'm not sure how to do it (yet), but mostly > because I don't have the hardware to test this (the 2 CODECs present on > my only i.MX6 board are both clock master)
Take a look at what the generic cards are doing, it's a library function asoc_simple_parse_daifmt(). It's not the end of the world if you can't test it properly - if it turns out it's buggy somehow someone can always fix the code later but an ABI is an ABI so we can't change it. [unhandled content-type:application/pgp-signature] | |