Messages in this thread | | | From | Anson Huang <> | Subject | RE: [PATCH V2 3/9] clk: imx: Support building SCU clock driver as module | Date | Thu, 2 Jul 2020 06:15:05 +0000 |
| |
Hi, Arnd/Stephen
> Subject: Re: [PATCH V2 3/9] clk: imx: Support building SCU clock driver as > module > > Quoting Arnd Bergmann (2020-06-29 01:19:44) > > On Mon, Jun 29, 2020 at 9:18 AM Dong Aisheng <dongas86@gmail.com> > wrote: > > > On Thu, Jun 25, 2020 at 6:43 AM Stephen Boyd <sboyd@kernel.org> > wrote: > > > > Quoting Aisheng Dong (2020-06-23 19:59:09) Why aren't there > > > > options to enable clk-imx6q and clk-imx6sl in the clk/imx/Kconfig > > > > file? Those can be bool or tristate depending on if the SoC > > > > drivers use CLK_OF_DECLARE or not and depend on the mxc-clk > > > > library and SoC config we have in the makefile today. > > > > > > Yes, we can do that in clk/imx/Kconfig as follows theoretically. > > > config CLK_IMX6Q > > > bool > > > def_bool ARCH_MXC && ARM > > > select MXC_CLK > > > > > > But we have totally 15 platforms that need to change. > > > > I would make that > > > > config CLK_IMX6Q > > bool "Clock driver for NXP i.MX6Q" > > depends on SOC_IMX6Q || COMPILE_TEST > > default SOC_IMX6Q > > select MXC_CLK > > Yes, do this.
The COMPILE_TEST existing on the config will introduce some build error on other ARCH's allyesconfig build on i.MX2/3 platforms, I received some build error report. So in next patch series, I will drop the COMPILE_TEST for these new added clock configurations, as I think it is NOT worth to support the COMPILE_TEST for these old legacy platforms which are NOT supported before.
Thanks, Anson
| |