Messages in this thread | | | Subject | Re: [v4 02/14] irqchip/csky-apb-intc: Fix potential resource leaks | From | Tiezhu Yang <> | Date | Thu, 2 Jul 2020 20:35:58 +0800 |
| |
On 07/02/2020 08:24 PM, Markus Elfring wrote: >>>>>>> +++ b/drivers/irqchip/irq-csky-apb-intc.c > … >> Let us keep it as it is > I propose to reconsider also this view. > > >> to make the code clear and to avoid the alignment issue: >> >> ret = foo(); >> if (ret) { >> ret = -ENOMEM; > How do you think about to delete this assignment if you would like to > reuse the return value from a call of the function “irq_alloc_domain_generic_chips”?
OK, looks good to me, thank you.
> > >> goto ... >> } > > Please apply a known script also for the purpose to achieve consistent indentation. > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/scripts/checkpatch.pl?id=cd77006e01b3198c75fb7819b3d0ff89709539bb#n3301
OK
> > Regards, > Markus
| |