Messages in this thread | | | From | Arnd Bergmann <> | Date | Thu, 2 Jul 2020 09:43:04 +0200 | Subject | Re: [PATCH V4 3/5] clk: imx: Support building i.MX common clock driver as module |
| |
On Thu, Jul 2, 2020 at 9:12 AM Anson Huang <anson.huang@nxp.com> wrote: > > > > The question is whether the #ifdef check in the header to test for MODULE > > (only calling it if this particular soc has a built-in clk driver, which is sufficient) > > or for IS_MODULE(CONFIG_MXC_CLK) (call it if _any_ clk driver is built-in and > > the function exists, which leaves extra code in the driver but is a more > > conventional check). > > > > So you prefer to add an empty inline function for imx_register_uart_clocks() with check > of MODULE build?
Yes, I want the empty inline stub, but either symbol check would work
> Even with this, we still need to add MODULE build check to whole block > of this earlycon uart clock handler in imx/clk.c.
Correct.
Arnd
| |