Messages in this thread Patch in this message | | | From | Baolin Wang <> | Subject | [PATCH 3/5] nvme-pci: Remove redundant segment validation | Date | Fri, 3 Jul 2020 10:49:22 +0800 |
| |
We've validated the segment counts before calling nvme_map_data(), so there is no need to validate again in nvme_pci_use_sgls() only called from nvme_map_data().
Signed-off-by: Baolin Wang <baolin.wang@linux.alibaba.com> --- drivers/nvme/host/pci.c | 3 --- 1 file changed, 3 deletions(-)
diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c index d0e9bbf..63bfb8b 100644 --- a/drivers/nvme/host/pci.c +++ b/drivers/nvme/host/pci.c @@ -501,9 +501,6 @@ static inline bool nvme_pci_use_sgls(struct nvme_dev *dev, struct request *req) int nseg = blk_rq_nr_phys_segments(req); unsigned int avg_seg_size; - if (nseg == 0) - return false; - avg_seg_size = DIV_ROUND_UP(blk_rq_payload_bytes(req), nseg); if (!(dev->ctrl.sgls & ((1 << 0) | (1 << 1)))) -- 1.8.3.1
| |