lkml.org 
[lkml]   [2020]   [Jul]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 2/4] staging: rtl8188eu: include: fixed multiple parentheses coding style issues
On Sun, Jul 19, 2020 at 5:26 AM Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> On Sat, Jul 18, 2020 at 05:16:26AM -0400, B K Karthik wrote:
> > fixed multiple parentheses coding style issues reported by checkpatch.
> >
> > Signed-off-by: B K Karthik <karthik.bk2000@live.com>
> > ---
> > drivers/staging/rtl8188eu/include/ieee80211.h | 4 +--
> > .../staging/rtl8188eu/include/osdep_service.h | 4 +--
> > drivers/staging/rtl8188eu/include/wifi.h | 34 +++++++++----------
> > 3 files changed, 21 insertions(+), 21 deletions(-)
>
> You can never add warnings to the build, like this patch did. Always
> test-build your patches at the very least...

understood, I will definitely do that.
but these warnings are (mostly) [-Wunused-value] and [-Wformat].
that should not have (?) occurred due to the usage of parentheses.

anyways, I will try to fix these up and send a v2.
sorry if i wasted your time

karthik

\
 
 \ /
  Last update: 2020-07-19 11:36    [W:0.068 / U:1.304 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site