Messages in this thread | | | From | Johnson CH Chen (陳昭勳) <> | Subject | RE: linux-next: Tree for Jul 17 (drivers/rtc/rtc-ds1374.o) | Date | Mon, 20 Jul 2020 03:46:15 +0000 |
| |
Hi Stephen,
> From: Stephen Rothwell <sfr@canb.auug.org.au> > Sent: Saturday, July 18, 2020 9:39 AM > To: Randy Dunlap <rdunlap@infradead.org> > Cc: Linux Next Mailing List <linux-next@vger.kernel.org>; Linux Kernel Mailing > List <linux-kernel@vger.kernel.org>; linux-rtc@vger.kernel.org; Alessandro > Zummo <a.zummo@towertech.it>; Alexandre Belloni > <alexandre.belloni@bootlin.com>; Scott Wood <scottwood@freescale.com>; > Johnson CH Chen (陳昭勳) <JohnsonCH.Chen@moxa.com> > Subject: Re: linux-next: Tree for Jul 17 (drivers/rtc/rtc-ds1374.o) > > Hi Randy, > > [Please trim your emails a bit more, thanks] > > On Fri, 17 Jul 2020 09:49:05 -0700 Randy Dunlap <rdunlap@infradead.org> > wrote: > > on x86_64: > > # CONFIG_WATCHDOG is not set > >
Thanks for your information.
It seems RTC_DRV_DS1374_WDT should be depended on RTC_DRV_DS1374 && WATCHDOG_CORE. Otherwise error will happen if RTC_DRV_DS1374_WDT is enabled but WATCHDOG_CORE not. I'll put this into v5 if there are no other suggestions.
Should I add " Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>" into v5? So many thanks!
> > ld: drivers/rtc/rtc-ds1374.o: in function `ds1374_probe': > > rtc-ds1374.c:(.text+0x736): undefined reference to > `watchdog_init_timeout' > > ld: rtc-ds1374.c:(.text+0x77e): undefined reference to > `devm_watchdog_register_device' > > Caused by commit > > d3de4beb14a8 ("rtc: ds1374: wdt: Use watchdog core for watchdog > part") > > from the rtc tree. > -- > Cheers, > Stephen Rothwell
Best regards, Johnson
| |