Messages in this thread | | | From | "Oliver O'Halloran" <> | Date | Mon, 20 Jul 2020 11:15:59 +1000 | Subject | Re: [PATCH v2] powerpc/powernv/pci: use ifdef to avoid dead code |
| |
On Sun, Jul 19, 2020 at 5:13 AM Greg Thelen <gthelen@google.com> wrote: > > Oliver O'Halloran <oohall@gmail.com> wrote: > > > On Mon, Jun 15, 2020 at 9:33 AM Greg Thelen <gthelen@google.com> wrote: > >> > >> Commit dc3d8f85bb57 ("powerpc/powernv/pci: Re-work bus PE > >> configuration") removed a couple pnv_ioda_setup_bus_dma() calls. The > >> only remaining calls are behind CONFIG_IOMMU_API. Thus builds without > >> CONFIG_IOMMU_API see: > >> arch/powerpc/platforms/powernv/pci-ioda.c:1888:13: error: 'pnv_ioda_setup_bus_dma' defined but not used > >> > >> Move pnv_ioda_setup_bus_dma() under CONFIG_IOMMU_API to avoid dead code. > > > > Doh! Thanks for the fix. > > > > Reviewed-by: Oliver O'Halloran <oohall@gmail.com> > > Is there anything else needed from me on this patch? > Given that it fixes a 5.8 commit I figured it'd be 5.8 material.
Oh sorry, I completely forgot about this patch. I sent another series that included a more-or-less identical fix after the kbuild robot sent a reminder:
http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=187630&state=*
That's current in powerpc/next, but if it's causing a build break then I agree it should probably go into 5.8 too.
Oliver
| |