lkml.org 
[lkml]   [2020]   [Jul]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH net-next 3/4] net: Call into DSA netdevice_ops wrappers
From
Date


On 7/19/2020 9:04 AM, Andrew Lunn wrote:
>> If we have the core network stack reference DSA as a module then we
>> force DSA to be either built-in or not, which is not very practical,
>> people would still want a modular choice to be possible. The static
>> inline only wraps indirect function pointer calls using definitions
>> available at build time and actual function pointer substitution at run
>> time, so we avoid that problem entirely that way.
>
> Hi Florian
>
> The jumping through the pointer avoids the inbuilt vs module problems.
>
> The helpers themselves could be in a net/core/*.c file, rather than
> static inline in a header. Is it worth adding a net/core/dsa.c for
> code which must always be built in? At the moment, probably not. But
> if we have more such redirect, maybe it would be?
I would continue to put what is DSA specific in net/dsa.h an not
introduce new files within net/core/ that we could easily miss while
updating DSA or we would need to update the MAINTAINERS file for etc.
--
Florian

\
 
 \ /
  Last update: 2020-07-19 18:08    [W:0.041 / U:0.420 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site