lkml.org 
[lkml]   [2020]   [Jul]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 17/30] iio: gyro: adxrs450: Change ordering of compiler attribute macro
On Fri, 17 Jul 2020 17:55:25 +0100
Lee Jones <lee.jones@linaro.org> wrote:

> Kerneldoc gets confused if the variable does not follow the
> type/attribute definitions.
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/iio/gyro/adxrs450.c:79: warning: Function parameter or member '____cacheline_aligned' not described in 'adxrs450_state'
>
> Cc: Michael Hennerich <Michael.Hennerich@analog.com>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
Holding this one for the conversation about whether we should be fixing
the code or the tool.

Thanks,

Jonathan

> ---
> drivers/iio/gyro/adxrs450.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/gyro/adxrs450.c b/drivers/iio/gyro/adxrs450.c
> index b00c0eb442493..e00b97e30cf9d 100644
> --- a/drivers/iio/gyro/adxrs450.c
> +++ b/drivers/iio/gyro/adxrs450.c
> @@ -73,7 +73,7 @@ enum {
> struct adxrs450_state {
> struct spi_device *us;
> struct mutex buf_lock;
> - __be32 tx ____cacheline_aligned;
> + __be32 ____cacheline_aligned tx;
> __be32 rx;
>
> };

\
 
 \ /
  Last update: 2020-07-18 17:53    [W:0.903 / U:0.332 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site