Messages in this thread | | | From | "Mani, Rajmohan" <> | Subject | RE: [PATCH 2/2] usb: typec: intel_pmc_mux: Check the port status before connect | Date | Fri, 17 Jul 2020 06:04:51 +0000 |
| |
Hi Greg,
> -----Original Message----- > From: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Sent: Thursday, July 16, 2020 12:05 AM > To: Mani, Rajmohan <rajmohan.mani@intel.com> > Cc: Darren Hart <dvhart@infradead.org>; Andy Shevchenko > <andy@infradead.org>; Mika Westerberg > <mika.westerberg@linux.intel.com>; Dmitry Torokhov > <dmitry.torokhov@gmail.com>; Lee Jones <lee.jones@linaro.org>; Ayman > Bagabas <ayman.bagabas@gmail.com>; Masahiro Yamada > <masahiroy@kernel.org>; Joseph, Jithu <jithu.joseph@intel.com>; Blaž > Hrastnik <blaz@mxxn.io>; Srinivas Pandruvada > <srinivas.pandruvada@linux.intel.com>; linux-kernel@vger.kernel.org; > platform-driver-x86@vger.kernel.org; Heikki Krogerus > <heikki.krogerus@linux.intel.com>; linux-usb@vger.kernel.org; > pmalani@chromium.org; bleung@chromium.org > Subject: Re: [PATCH 2/2] usb: typec: intel_pmc_mux: Check the port status > before connect > > On Wed, Jul 15, 2020 at 05:33:10PM -0700, Rajmohan Mani wrote: > > From: Heikki Krogerus <heikki.krogerus@linux.intel.com> > > > > The PMC microcontroller that we use for configuration, does not supply > > any status information back. For port status we need to talk to > > another controller on the board called IOM (I/O manager). > > > > By checking the port status before configuring the muxes, we can make > > sure that we do not reconfigure the port after bootup when the system > > firmware (for example BIOS) has already configured it. > > > > Using the status information also to check if DisplayPort HPD is still > > asserted when the cable plug is disconnected, and clearing it if it > > is. > > > > Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> > > You can't just forward on patches from others without also adding your > signed-off-by to them, right? >
Sorry I missed this.
> Please fix up this series and try again. >
Ack. Will fix this with v2.
> thanks, > > greg k-h
| |