lkml.org 
[lkml]   [2020]   [Jul]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2 07/14] spi: spi-s3c64xx: Add missing entries for structs 's3c64xx_spi_dma_data' and 's3c64xx_spi_dma_data'
    Date
    Fixes the following W=1 kernel build warning(s):

    drivers/spi/spi-s3c64xx.c:150: warning: Function parameter or member 'quirks' not described in 's3c64xx_spi_port_config'
    drivers/spi/spi-s3c64xx.c:150: warning: Function parameter or member 'clk_ioclk' not described in 's3c64xx_spi_port_config'
    drivers/spi/spi-s3c64xx.c:189: warning: Function parameter or member 'pdev' not described in 's3c64xx_spi_driver_data'
    drivers/spi/spi-s3c64xx.c:189: warning: Function parameter or member 'rx_dma' not described in 's3c64xx_spi_driver_data'
    drivers/spi/spi-s3c64xx.c:189: warning: Function parameter or member 'tx_dma' not described in 's3c64xx_spi_driver_data'
    drivers/spi/spi-s3c64xx.c:189: warning: Function parameter or member 'port_conf' not described in 's3c64xx_spi_driver_data'
    drivers/spi/spi-s3c64xx.c:189: warning: Function parameter or member 'port_id' not described in 's3c64xx_spi_driver_data'

    Cc: Kukjin Kim <kgene@kernel.org>
    Cc: Krzysztof Kozlowski <krzk@kernel.org>
    Cc: Andi Shyti <andi@etezian.org>
    Cc: Jaswinder Singh <jassi.brar@samsung.com>
    Cc: linux-samsung-soc@vger.kernel.org
    Signed-off-by: Lee Jones <lee.jones@linaro.org>
    ---
    drivers/spi/spi-s3c64xx.c | 9 ++++++++-
    1 file changed, 8 insertions(+), 1 deletion(-)

    diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c
    index cf67ea60dc0ed..924b24441789a 100644
    --- a/drivers/spi/spi-s3c64xx.c
    +++ b/drivers/spi/spi-s3c64xx.c
    @@ -130,9 +130,11 @@ struct s3c64xx_spi_dma_data {
    * @fifo_lvl_mask: Bit-mask for {TX|RX}_FIFO_LVL bits in SPI_STATUS register.
    * @rx_lvl_offset: Bit offset of RX_FIFO_LVL bits in SPI_STATUS regiter.
    * @tx_st_done: Bit offset of TX_DONE bit in SPI_STATUS regiter.
    + * @quirks: Bitmask of known quirks
    * @high_speed: True, if the controller supports HIGH_SPEED_EN bit.
    * @clk_from_cmu: True, if the controller does not include a clock mux and
    * prescaler unit.
    + * @clk_ioclk: True if clock is present on this device
    *
    * The Samsung s3c64xx SPI controller are used on various Samsung SoC's but
    * differ in some aspects such as the size of the fifo and spi bus clock
    @@ -154,6 +156,7 @@ struct s3c64xx_spi_port_config {
    * @clk: Pointer to the spi clock.
    * @src_clk: Pointer to the clock used to generate SPI signals.
    * @ioclk: Pointer to the i/o clock between master and slave
    + * @pdev: Pointer to device's platform device data
    * @master: Pointer to the SPI Protocol master.
    * @cntrlr_info: Platform specific data for the controller this driver manages.
    * @lock: Controller specific lock.
    @@ -166,7 +169,11 @@ struct s3c64xx_spi_port_config {
    * @xfer_completion: To indicate completion of xfer task.
    * @cur_mode: Stores the active configuration of the controller.
    * @cur_bpw: Stores the active bits per word settings.
    - * @cur_speed: Stores the active xfer clock speed.
    + * @cur_speed: Current clock speed
    + * @rx_dma: Local receive DMA data (e.g. chan and direction)
    + * @tx_dma: Local transmit DMA data (e.g. chan and direction)
    + * @port_conf: Local SPI port configuartion data
    + * @port_id: Port identification number
    */
    struct s3c64xx_spi_driver_data {
    void __iomem *regs;
    --
    2.25.1
    \
     
     \ /
      Last update: 2020-07-17 15:55    [W:3.521 / U:0.356 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site