Messages in this thread | | | From | Sedat Dilek <> | Date | Fri, 17 Jul 2020 07:49:02 +0200 | Subject | Re: [PATCH] tools/memory-model: document the "one-time init" pattern |
| |
On Fri, Jul 17, 2020 at 6:48 AM Eric Biggers <ebiggers@kernel.org> wrote: > > From: Eric Biggers <ebiggers@google.com> ... > This is motivated by the discussion at > https://lkml.kernel.org/linux-fsdevel/20200713033330.205104-1-ebiggers@kernel.org/T/#u ... > +In where cases where taking the mutex in the "already initialized" case
"In cases where..." (drop first "where")
> +presents scalability concerns, the implementation can be optimized to > +check the 'inited' flag outside the mutex. Unfortunately, this > +optimization is often implemented incorrectly by using a plain load. > +That violates the memory model and may result in unpredictable behavior.
- Sedat -
| |