Messages in this thread | | | Date | Fri, 17 Jul 2020 11:13:27 +0200 | From | Alexandre Belloni <> | Subject | Re: [PATCH 05/19] clk: at91: sam9x60-pll: use logical or for range check |
| |
On 15/07/2020 14:24:13+0300, Claudiu Beznea wrote: > Use logical or for range check. In case bestrate is not in > characteristics->output[0].min..characteristics->output[0].max > range we should return -ERANGE. > > Fixes: a436c2a447e59 ("clk: at91: add sam9x60 PLL driver") > Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com> Reviewed-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
> --- > drivers/clk/at91/clk-sam9x60-pll.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clk/at91/clk-sam9x60-pll.c b/drivers/clk/at91/clk-sam9x60-pll.c > index d3152c0afcbf..dfb91c190bd1 100644 > --- a/drivers/clk/at91/clk-sam9x60-pll.c > +++ b/drivers/clk/at91/clk-sam9x60-pll.c > @@ -232,7 +232,7 @@ static long sam9x60_pll_get_best_div_mul(struct sam9x60_pll *pll, > } > > /* Check if bestrate is a valid output rate */ > - if (bestrate < characteristics->output[0].min && > + if (bestrate < characteristics->output[0].min || > bestrate > characteristics->output[0].max) > return -ERANGE; > > -- > 2.7.4 >
-- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
| |