Messages in this thread | | | Subject | Re: [PATCH] perf evsel: Don't set sample_regs_intr/sample_regs_user for dummy event | From | "Jin, Yao" <> | Date | Fri, 17 Jul 2020 16:30:21 +0800 |
| |
On 7/17/2020 4:24 PM, Jiri Olsa wrote: > On Fri, Jul 17, 2020 at 11:33:46AM +0800, Jin, Yao wrote: >> Hi, >> >> On 7/6/2020 8:55 AM, Jin, Yao wrote: >>> Hi Ian, >>> >>> On 7/6/2020 8:47 AM, Ian Rogers wrote: >>>> On Fri, Jul 3, 2020 at 5:31 PM Jin, Yao <yao.jin@linux.intel.com> wrote: >>>>> >>>>> Hi Jiri, >>>>> >>>>> On 7/3/2020 7:00 PM, Jiri Olsa wrote: >>>>>> On Fri, Jul 03, 2020 at 08:42:15AM +0800, Jin Yao wrote: >>>>>>> Since commit 0a892c1c9472 ("perf record: Add dummy event during system wide synthesis"), >>>>>>> a dummy event is added to capture mmaps. >>>>>>> >>>>>>> But if we run perf-record as, >>>>>>> >>>>>>> # perf record -e cycles:p -IXMM0 -a -- sleep 1 >>>>>>> Error: >>>>>>> dummy:HG: PMU Hardware doesn't support sampling/overflow-interrupts. Try 'perf stat' >>>>>>> >>>> >>>> Sorry for the breakage caused by modifying the dummy event. Could we >>>> add a test to cover the issue? Perhaps in tools/perf/tests/shell/. >>>> Trying to reproduce with a register on my skylakex on a 5.6.14 kernel >>>> with: >>>> >>>> $ perf record -e cycles:p -IAX -a -- sleep 1 >>>> >>>> succeeds. >>>> >>>> Thanks, >>>> Ian >>>> >>> >>> -IAX should be no problem. The issue only occurs on the platform with >>> extended regs supports, such as ICL. So I don't know if it's suitable to >>> add it to perf test suite. >>> >>> Thanks >>> Jin Yao >>> >> >> Can this fix patch be accepted? > > hi, > my only concern was that it would conflict with Adrian's patch, > other than that: > > Acked-by: Jiri Olsa <jolsa@redhat.com> > > thanks, > jirka >
Thanks Jiri!
Adrian's patch has not been merged otherwise I can rebase my patch on top of Adrian's patch.
Thanks Jin Yao
| |