Messages in this thread | | | Date | Fri, 17 Jul 2020 18:56:11 -0700 (PDT) | Subject | Re: [net-next PATCH v3 1/7] hsr: enhance netlink socket interface to support PRP | From | David Miller <> |
| |
From: Murali Karicheri <m-karicheri2@ti.com> Date: Fri, 17 Jul 2020 11:15:05 -0400
> @@ -32,7 +33,9 @@ static int hsr_newlink(struct net *src_net, struct net_device *dev, > struct netlink_ext_ack *extack) > { > struct net_device *link[2]; > - unsigned char multicast_spec, hsr_version; > + unsigned char multicast_spec; > + enum hsr_version proto_version; > + u8 proto = HSR_PROTOCOL_HSR;
Please use reverse christmas tree ordering for local variables.
Thank you.
| |