Messages in this thread | | | Date | Fri, 17 Jul 2020 23:54:42 +0200 | From | Michael Walle <> | Subject | Re: [PATCH v5 12/13] arm64: dts: freescale: sl28: enable LED support |
| |
Hi Pavel,
Am 2020-07-17 10:36, schrieb Pavel Machek: > Hi! > >> Now that we have support for GPIO lines of the SMARC connector, enable >> LED support on the KBox A-230-LS. There are two LEDs without fixed >> functions, one is yellow and one is green. Unfortunately, it is just >> one >> multi-color LED, thus while it is possible to enable both at the same >> time it is hard to tell the difference between "yellow only" and >> "yellow >> and green". > >> + user_yellow { >> + label = "s1914:yellow:user"; >> + gpios = <&sl28cpld_gpio0 0 0>; >> + }; >> + >> + user_green { >> + label = "s1914:green:user"; >> + gpios = <&sl28cpld_gpio1 3 0>; >> + }; > > This is not suitable label for such LEDs... there's zero chance > userland will > know what to do with these. > > Do they have some kind of "usual" function?
Unfortunately, they do not. I guess the green one could be something like "application ready" and the yellow one could be an indication that some fault occurred.
Do you have any suggestions?
-michael
| |