lkml.org 
[lkml]   [2020]   [Jul]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] net: cxgb3: add missed destroy_workqueue in cxgb3 probe failure
From
Date
> Add the missed calls to fix it.

You propose to add only a single function call.



> +++ b/drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c
> @@ -3407,6 +3407,7 @@ static int init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
> out_disable_device:
> pci_disable_device(pdev);
> out:
> + destroy_workqueue(cxgb3_wq);
> return err;
> }

I suggest to adjust also the usage of the label “out” accordingly.

Regards,
Markus

\
 
 \ /
  Last update: 2020-07-17 21:20    [W:0.125 / U:0.208 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site