lkml.org 
[lkml]   [2020]   [Jul]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH V3 1/3] PCI: Add defines for Designated Vendor-Specific Capability
From
Date


On 7/15/2020 7:55 PM, Randy Dunlap wrote:
> On 7/13/20 11:23 PM, David E. Box wrote:
>> Add PCIe DVSEC extended capability ID and defines for the header offsets.
>> Defined in PCIe r5.0, sec 7.9.6.
>>
>> Signed-off-by: David E. Box <david.e.box@linux.intel.com>
>> Acked-by: Bjorn Helgaas <bhelgaas@google.com>
>> ---
>> include/uapi/linux/pci_regs.h | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/include/uapi/linux/pci_regs.h b/include/uapi/linux/pci_regs.h
>> index f9701410d3b5..09daa9f07b6b 100644
>> --- a/include/uapi/linux/pci_regs.h
>> +++ b/include/uapi/linux/pci_regs.h
>> @@ -720,6 +720,7 @@
>> +#define PCI_EXT_CAP_ID_DVSEC 0x23 /* Designated Vendor-Specific */
>> @@ -1062,6 +1063,10 @@
>> +/* Designated Vendor-Specific (DVSEC, PCI_EXT_CAP_ID_DVSEC) */
>> +#define PCI_DVSEC_HEADER1 0x4 /* Vendor-Specific Header1 */
>> +#define PCI_DVSEC_HEADER2 0x8 /* Vendor-Specific Header2 */
>
> Just a little comment: It would make more sense to me to
> s/DVSEC/DVSPEC/g.
>
> But then I don't have the PCIe documentation.

Arguably some of the confusion might be from the patch title. DVSEC is
acronym for Designated Vendor-Specific Extended Capability if I recall
correctly. It would probably be best to call that out since the extended
implies it lives in the config space accessible via the memory mapped
config.

\
 
 \ /
  Last update: 2020-07-16 19:19    [W:0.109 / U:0.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site