Messages in this thread | | | Date | Thu, 16 Jul 2020 08:29:36 +0200 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH v3 1/2] platform/chrome: cros_ec_uart: Add cros-ec-uart transport layer |
| |
On Thu, Jul 16, 2020 at 08:28:07AM +0200, Greg Kroah-Hartman wrote: > On Wed, Jul 15, 2020 at 10:14:29PM -0700, Bhanu Prakash Maiya wrote: > > From: Bhanu Prakash Maiya <bhanumaiya@chromium.org> > > > > This patch enables uart transport layer for cros_ec framework. > > The cros-ec-uart binds with EC device working on uart transport to > > send request and receive response. > > > > Signed-off-by: Bhanu Prakash Maiya <bhanumaiya@chromium.org> > > If this really is a "UART", why is this not a serial/tty driver?
Ah, it's a serdev driver. that wasn't obvious.
Please write a much better changelog saying what this driver is and why it needs to be the type that it is, as I totally missed that from these 2 sentences.
thanks,
greg k-h
| |