Messages in this thread | | | Subject | Re: [PATCH] net: smc91x: Fix possible memory leak in smc_drv_probe() | From | Markus Elfring <> | Date | Thu, 16 Jul 2020 08:20:34 +0200 |
| |
> If try_toggle_control_gpio() failed in smc_drv_probe(), free_netdev(ndev) > should be called to free the ndev created earlier. Otherwise, a memleak > will occur.
* Will it be nicer to use the term “memory leak” also in this change description?
* Would another imperative wording be preferred for the commit message? https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=f8456690ba8eb18ea4714e68554e242a04f65cff#n151
Regards, Markus
| |