Messages in this thread Patch in this message | | | Date | Thu, 16 Jul 2020 15:30:33 -0000 | From | "tip-bot2 for Arnd Bergmann" <> | Subject | [tip: x86/urgent] x86: math-emu: Fix up 'cmp' insn for clang ias |
| |
The following commit has been merged into the x86/urgent branch of tip:
Commit-ID: 81e96851ea32deb2c921c870eecabf335f598aeb Gitweb: https://git.kernel.org/tip/81e96851ea32deb2c921c870eecabf335f598aeb Author: Arnd Bergmann <arnd@arndb.de> AuthorDate: Wed, 27 May 2020 15:53:46 +02:00 Committer: Thomas Gleixner <tglx@linutronix.de> CommitterDate: Thu, 16 Jul 2020 17:26:42 +02:00
x86: math-emu: Fix up 'cmp' insn for clang ias
The clang integrated assembler requires the 'cmp' instruction to have a length prefix here:
arch/x86/math-emu/wm_sqrt.S:212:2: error: ambiguous instructions require an explicit suffix (could be 'cmpb', 'cmpw', or 'cmpl') cmp $0xffffffff,-24(%ebp) ^
Make this a 32-bit comparison, which it was clearly meant to be.
Signed-off-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Reviewed-by: Nick Desaulniers <ndesaulniers@google.com> Link: https://lkml.kernel.org/r/20200527135352.1198078-1-arnd@arndb.de
--- arch/x86/math-emu/wm_sqrt.S | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/math-emu/wm_sqrt.S b/arch/x86/math-emu/wm_sqrt.S index 3b2b581..40526dd 100644 --- a/arch/x86/math-emu/wm_sqrt.S +++ b/arch/x86/math-emu/wm_sqrt.S @@ -209,7 +209,7 @@ sqrt_stage_2_finish: #ifdef PARANOID /* It should be possible to get here only if the arg is ffff....ffff */ - cmp $0xffffffff,FPU_fsqrt_arg_1 + cmpl $0xffffffff,FPU_fsqrt_arg_1 jnz sqrt_stage_2_error #endif /* PARANOID */
| |