lkml.org 
[lkml]   [2020]   [Jul]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V5] drivers/nvme: Add support for ACPI StorageD3Enable property
On Mon, Jul 13, 2020 at 01:12:26PM +0200, Rafael J. Wysocki wrote:
> I would write this as
>
> if (fwnode_property_read_u8(acpi_fwnode_handle(adev),
> "StorageD3Enable", &val))
> return false;
>
> return val == 1;
>
> to eliminate the redundant fwnode variable and untangle the last
> checks somewhat.
>
> With that changed please feel free to add
>
> Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

Applied to nvme-5.9 with the above fixup.

\
 
 \ /
  Last update: 2020-07-16 16:40    [W:0.065 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site