Messages in this thread | | | Date | Thu, 16 Jul 2020 15:34:50 +0100 | From | Mark Brown <> | Subject | Re: [PATCH] ASoC: meson: add the missed kfree() for axg_card_add_tdm_loopback |
| |
On Thu, Jul 16, 2020 at 03:29:39PM +0200, Jerome Brunet wrote: > On Thu 16 Jul 2020 at 15:25, Jing Xiangfeng <jingxiangfeng@huawei.com> wrote:
> > axg_card_add_tdm_loopback() misses to call kfree() in an error path. Add > > the missed function call to fix it. > > > > Fixes: c84836d7f650 ("ASoC: meson: axg-card: use modern dai_link style") > > Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
> Thanks for fixing this. > Maybe it would be better to use the devm_ variant for the name instead ?
Yes, that should be more robust. [unhandled content-type:application/pgp-signature] | |