Messages in this thread | | | From | Anup Patel <> | Date | Thu, 16 Jul 2020 18:49:42 +0530 | Subject | Re: [PATCH v2 1/2] riscv: Fix build warning for mm/init |
| |
On Thu, Jul 16, 2020 at 6:35 PM Zong Li <zong.li@sifive.com> wrote: > > Add static keyword for resource_init, this function is only used in this > object file. > > The warning message as follow (with W=1 build): > > arch/riscv/mm/init.c:520:13: > warning: no previous prototype for 'resource_init' [-Wmissing-prototypes] > > Signed-off-by: Zong Li <zong.li@sifive.com> > --- > arch/riscv/mm/init.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/riscv/mm/init.c b/arch/riscv/mm/init.c > index 92002952c621..66f5952f39c0 100644 > --- a/arch/riscv/mm/init.c > +++ b/arch/riscv/mm/init.c > @@ -517,7 +517,7 @@ void mark_rodata_ro(void) > } > #endif > > -void __init resource_init(void) > +static void __init resource_init(void) > { > struct memblock_region *region; > > -- > 2.27.0 >
Looks good to me.
Reviewed-by: Anup Patel <anup@brainfault.org>
Regards, Anup
| |