Messages in this thread | | | Subject | Re: ioremap and dma cleanups and fixes for superh (2nd resend) | From | John Paul Adrian Glaubitz <> | Date | Thu, 16 Jul 2020 13:30:04 +0200 |
| |
On 7/15/20 6:18 PM, John Paul Adrian Glaubitz wrote: > Found the culprit: > > c5b27a889da92f4a969d61df77bd4f79ffce57c9 is the first bad commit > commit c5b27a889da92f4a969d61df77bd4f79ffce57c9 > Author: Peter Zijlstra <peterz@infradead.org> > Date: Tue Sep 4 14:45:04 2018 +0200 > > sh/tlb: Convert SH to generic mmu_gather > > Generic mmu_gather provides everything SH needs (range tracking and > cache coherency). > > No change in behavior intended. > > Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> > Cc: Andrew Morton <akpm@linux-foundation.org> > Cc: Andy Lutomirski <luto@kernel.org> > Cc: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com> > Cc: Borislav Petkov <bp@alien8.de> > Cc: Dave Hansen <dave.hansen@linux.intel.com> > Cc: H. Peter Anvin <hpa@zytor.com> > Cc: Linus Torvalds <torvalds@linux-foundation.org> > Cc: Nick Piggin <npiggin@gmail.com> > Cc: Peter Zijlstra <peterz@infradead.org> > Cc: Rich Felker <dalias@libc.org> > Cc: Rik van Riel <riel@surriel.com> > Cc: Thomas Gleixner <tglx@linutronix.de> > Cc: Will Deacon <will.deacon@arm.com> > Cc: Yoshinori Sato <ysato@users.sourceforge.jp> > Signed-off-by: Ingo Molnar <mingo@kernel.org> > > arch/sh/include/asm/pgalloc.h | 9 +++ > arch/sh/include/asm/tlb.h | 130 +----------------------------------------- > 2 files changed, 10 insertions(+), 129 deletions(-) > > CC'ing the author (Peter Zijlstra <peterz@infradead.org>). This is fixed by [1]:
sh/tlb: Fix PGTABLE_LEVELS > 2
Geert reported that his SH7722-based Migo-R board failed to boot after commit:
c5b27a889da9 ("sh/tlb: Convert SH to generic mmu_gather")
That commit fell victim to copying the wrong pattern -- __pmd_free_tlb() used to be implemented with pmd_free().
Fixes: c5b27a889da9 ("sh/tlb: Convert SH to generic mmu_gather") Reported-by: Geert Uytterhoeven <geert@linux-m68k.org> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Tested-by: Geert Uytterhoeven <geert+renesas@glider.be>
I'm now running a current kernel on my SH-7785LCR with no issues.
Adrian
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git/commit/?h=mm/tlb&id=1f19a4bf8dcb42efc278940fb81c288c346b3eda
-- .''`. John Paul Adrian Glaubitz : :' : Debian Developer - glaubitz@debian.org `. `' Freie Universitaet Berlin - glaubitz@physik.fu-berlin.de `- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
| |