lkml.org 
[lkml]   [2020]   [Jul]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
SubjectRe: [PATCH] net: neterion: vxge: reduce stack usage in VXGE_COMPLETE_VPATH_TX
From
Date
On Thu, 2020-07-16 at 17:32 +0000, Bixuan Cui wrote:
> Fix the warning: [-Werror=-Wframe-larger-than=]
[]
> diff --git a/drivers/net/ethernet/neterion/vxge/vxge-main.c b/drivers/net/ethernet/neterion/vxge/vxge-main.c
[]
> @@ -100,8 +100,14 @@ static inline void VXGE_COMPLETE_VPATH_TX(struct vxge_fifo *fifo)
> struct sk_buff **temp;
> #define NR_SKB_COMPLETED 128
> struct sk_buff *completed[NR_SKB_COMPLETED];
> + struct sk_buff **completed;
> int more;
>
> + completed = kcalloc(NR_SKB_COMPLETED, sizeof(*completed),
> + GFP_KERNEL);

I doubt this is a good idea.
Check the callers interrupt status.


\
 
 \ /
  Last update: 2020-07-16 11:47    [W:0.096 / U:0.160 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site