lkml.org 
[lkml]   [2020]   [Jul]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v4 5/6] gpio: max77620: Use irqchip template
On Thu, Jul 9, 2020 at 7:12 PM Dmitry Osipenko <digetx@gmail.com> wrote:

> + mgpio->gpio_chip.irq.chip = &max77620_gpio_irqchip;
> + mgpio->gpio_chip.irq.default_type = IRQ_TYPE_NONE;
> + mgpio->gpio_chip.irq.handler = handle_edge_irq;
> + mgpio->gpio_chip.irq.threaded = true;

And I didn't even realize one could do this.

> - gpiochip_irqchip_add_nested(&mgpio->gpio_chip, &max77620_gpio_irqchip,
> - 0, handle_edge_irq, IRQ_TYPE_NONE);
> -
(...)
> - gpiochip_set_nested_irqchip(&mgpio->gpio_chip, &max77620_gpio_irqchip,
> - gpio_irq);

And get rid of these two.

I suppose I can just do the same for the remaining users of
gpiochip_irqchip_add_nested() and gpiochip_set_nested_irqchip()
and get rid of these two functions altogether!

Yours,
Linus Walleij

\
 
 \ /
  Last update: 2020-07-16 10:55    [W:0.078 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site