lkml.org 
[lkml]   [2020]   [Jul]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 1/1] irqchip: Add config MTK_SYSIRQ and MTK_CIRQ
On Tue, Jun 23, 2020 at 1:37 AM Marc Zyngier <maz@kernel.org> wrote:
>
> + Saravana
>
> On 2020-06-23 07:36, Hanks Chen wrote:
>
> [...]
>
> > Hi Marc,
> >
> > I want to break the dependency between ARCH_MEDIATEK and CIRQ/SYSIRQ,
> > because we need to follow the GKI.
>
> This isn't what GKI mandates. GKI requires that the SoC code is compiled
> as modules, not that it is dissociated from its platform (which would
> be completely pointless).
>
> > Could I add the MTK_CIRQ and MTK_SYSIRQ into defconfig?
> > (arch/arm64/config/defconfig)
>
> I don't deal with defconfig at all. That's a patch for the arm-soc
> people.
>
> >
> > It would ensures all platform are executable.
> >
> > e.g.
> > --- a/arch/arm64/configs/defconfig
> > +++ b/arch/arm64/configs/defconfig
> >
> > CONFIG_QCOM_PDC=y
> > +CONFIG_MTK_SYSIRQ=m
> > +CONFIG_MTK_CIRQ=y
> > CONFIG_RESET_QCOM_AOSS=y
> >
> > --- a/drivers/irqchip/Kconfig
> > +++ b/drivers/irqchip/Kconfig
> > @@ -572,4 +572,18 @@ config LOONGSON_PCH_MSI
> > help
> > Support for the Loongson PCH MSI Controller.
> >
> > +config MTK_SYSIRQ
> > + tristate "Mediatek interrupt polarity controller"
> > + depends on ARCH_MEDIATEK || COMPILE_TEST
> > + help
> > + Interrupt polarity controller driver to swap polarity for
> > + interrupts for Mediatek mobile chips.
> > +
> > +config MTK_CIRQ
> > + bool "Mediatek low-power interrupt controller"
> > + depends on ARCH_MEDIATEK || COMPILE_TEST
> > + help
> > + Low-power interrupt controller driver to monitor IRQS
> > + in the sleep mode for Mediatek mobile chips.
> > +
> >
> >
> > P.S I'll make the irq-mtk-sysirq driver as a loadable kernel module for
> > GKI
>
> You might as well turn both drivers into modules. Saravana was working
> on a set of patches to ease this transition.

Sent out v2 of that patch now.
https://lore.kernel.org/lkml/20200717024447.3128361-1-saravanak@google.com/T/#u

-Saravana

\
 
 \ /
  Last update: 2020-07-17 04:56    [W:0.052 / U:0.844 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site