lkml.org 
[lkml]   [2020]   [Jul]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] dt-bindings: uniphier-thermal: add minItems to socionext,tmod-calibration
On Tue, Jul 07, 2020 at 07:23:38PM +0900, Masahiro Yamada wrote:
> As the description says, this property contains a pair of calibration
> values. The number of items must be exactly 2.
>
> Add minItems to check a too short property.
>
> While I was here, I also added this property to the example because
> this is the case in the real DT file,
> arch/arm64/boot/dts/socionext/uniphier-ld20.dtsi
>
> Also, fix the interrupt type (edge -> level) to align with the
> real DT.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
> .../bindings/thermal/socionext,uniphier-thermal.yaml | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/thermal/socionext,uniphier-thermal.yaml b/Documentation/devicetree/bindings/thermal/socionext,uniphier-thermal.yaml
> index 553c9dcdaeeb..57ffd0c4c474 100644
> --- a/Documentation/devicetree/bindings/thermal/socionext,uniphier-thermal.yaml
> +++ b/Documentation/devicetree/bindings/thermal/socionext,uniphier-thermal.yaml
> @@ -29,6 +29,7 @@ properties:
>
> socionext,tmod-calibration:
> $ref: /schemas/types.yaml#/definitions/uint32-array
> + minItems: 2

The intent was if minItems is not defined, then the default is the same
as maxItems. This is not the default for json-schema, so the tooling is
supposed to add it. But looking at processed-schema.yaml, it doesn't
seem to be happening for one case here. I'm working on a fix in the
tools.

Rob

\
 
 \ /
  Last update: 2020-07-17 01:10    [W:0.103 / U:0.648 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site