lkml.org 
[lkml]   [2020]   [Jul]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 1/2] tracefs: Remove unnecessary debug_fs checks.
    Date
    This is a preparation for debugfs restricted mode.
    We don't need debugfs to trace, the removed check stop tracefs to work
    if debugfs is not initialised. We instead tries to automount within
    debugfs and relay on it's handling. The code path is to create a
    backward compatibility from when tracefs was part of debugfs, it is now
    standalone and does not need debugfs. When debugfs is in restricted
    it is compiled in but not active and return EPERM to clients and
    tracefs wont work if it assumes it is active it is compiled in
    kernel.

    Reported-by: kernel test robot <lkp@intel.com>
    Signed-off-by: Peter Enderborg <peter.enderborg@sony.com>
    Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
    ---
    kernel/trace/trace.c | 4 +---
    1 file changed, 1 insertion(+), 3 deletions(-)

    diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
    index bb62269724d5..848f67a5f16d 100644
    --- a/kernel/trace/trace.c
    +++ b/kernel/trace/trace.c
    @@ -8945,9 +8945,7 @@ struct dentry *tracing_init_dentry(void)
    if (tr->dir)
    return NULL;

    - if (WARN_ON(!tracefs_initialized()) ||
    - (IS_ENABLED(CONFIG_DEBUG_FS) &&
    - WARN_ON(!debugfs_initialized())))
    + if (WARN_ON(!tracefs_initialized()))
    return ERR_PTR(-ENODEV);

    /*
    --
    2.17.1
    \
     
     \ /
      Last update: 2020-07-16 09:15    [W:4.057 / U:0.384 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site