Messages in this thread | | | From | Doug Anderson <> | Date | Thu, 16 Jul 2020 14:51:27 -0700 | Subject | Re: [PATCH v3 3/5] pinctrl: qcom: Use return value from irq_set_wake call |
| |
Hi,
On Thu, Jul 16, 2020 at 6:19 AM Linus Walleij <linus.walleij@linaro.org> wrote: > > On Mon, Jun 22, 2020 at 11:32 AM Maulik Shah <mkshah@codeaurora.org> wrote: > > > msmgpio irqchip is not using return value of irq_set_wake call. > > Start using it. > > > > Fixes: e35a6ae0eb3a ("pinctrl/msm: Setup GPIO chip in hierarchy") > > Signed-off-by: Maulik Shah <mkshah@codeaurora.org> > > Is this something that's causing regressions so I should apply it for > fixes, or is it fine to keep this with the rest of the series for v5.9?
I would let Maulik comment more, but as far as I can tell the function has been ignoring the return value of irq_set_irq_wake() for much longer. Presumably one could logically say:
Fixes: 6aced33f4974 ("pinctrl: msm: drop wake_irqs bitmap")
...though when you get past the commit that Maulik tagged you need a backport rather than a straight cherry-pick.
That would make me believe that there is no real hurry to land the fix here.
-Doug
| |